fix: move download and enable button to outside of details tab#59465
fix: move download and enable button to outside of details tab#59465mykh-hailo wants to merge 1 commit intonextcloud:masterfrom
Conversation
mykh-hailo
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
|
Can you please add screenshots? |
|
@susnux Here are the screenshots before and update. Screenshot for Wide Screens.
Screenshot for narrow screens.
P.S. We have the title and score and the button section is clipped on the left. To fix this issue, we have to fix NcAppSidebar component. |
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
b77e55c to
6834740
Compare
|
@susnux I updated the code with the latest master branch. |
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
3 times, most recently
from
ad3aa25 to
fb5dc2b
Compare
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
2 times, most recently
from
b8c5ed1 to
6bbca83
Compare
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
6bbca83 to
5d71884
Compare
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
5d71884 to
7dbb3fb
Compare
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
7dbb3fb to
51f2f6a
Compare
There was a problem hiding this comment.
Hi @mykh-hailo thanks a lot for the contribution!
I just tested this and there seems to be some problems with the limit apps to groups feature (it should be put onto a new line probably and not be positioned like a block element:
Grabacion.2026-04-13.163329.mp4
Additionally, there seems to be some problems with updating the internal state when using the enable, install or disable buttons so that always a full page reload is required to update the state:
Grabacion.2026-04-13.163527.mp4
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
51f2f6a to
a5fcfdf
Compare
|
@szaimen Thank you for your comments. |
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
3 times, most recently
from
4de7f7a to
6fac68b
Compare
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
6fac68b to
e44e937
Compare
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I tested again and it doesnt work correctly yet:
- After disabling the app, it should offer to enable the app again or remove it but disabling the app seems to remove it directly now which is incorrect
- Activating the checkbox to limit an app to a specific group always shows
No results. Instead it should show a dropdown that allows to select your groups
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
4f6c125 to
7ef5b23
Compare
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
mykh-hailo
force-pushed
the
fix/app-download-and-enable-button-position
branch
from
7ef5b23 to
45a49ec
Compare
@szaimen about the 2nd issue, I fixed the bug and made a commit. But about the 1st one, as far as I checked the master branch, force refresh to update the sidebar is originally from the master branch. |
5 participants
Summary
This change improves discoverability of app lifecycle actions in the App Store sidebar by moving install, update, remove, enable/disable, App API deploy options, and “delete data on remove” out of the Details tab and into the sidebar header description area, next to badges and the store rating.
The Details tab now focuses on group limits, dependencies, metadata, and links (interact section), while primary actions stay visible without switching tabs.
Checklist
3. to review, feature component)stable32)AI (if applicable)